-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Feature 12760 for python service properties #14263
base: trunk
Are you sure you want to change the base?
[py] Feature 12760 for python service properties #14263
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
@pujagani rbe test failed
I'll try to figure out what went wrong |
hm... I ran several failing tests on my local environment, and the tests passed successfully.
|
i'll resolve conflicts later next week |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
according to feature request #12760
I did the work as in the pull request #12767.
Unfortunately, that pull request was closed due to inactivity and conflicts with the trunk branch.
I checked the build results and test execution here: https://github.com/iampopovich/selenium/actions/runs/9928825190/job/27425721756.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
List
,Mapping
,Optional
, andSequence
in the service classes.service_args
with_service_args
and added property methods for better encapsulation.command_line_args
methods to use_service_args
in all service classes.Changes walkthrough 📝
service.py
Refactor Chromium service to use properties for service arguments
py/selenium/webdriver/chromium/service.py
List
,Mapping
,Optional
, andSequence
.service_args
with_service_args
and added property methods.command_line_args
method to use_service_args
.service.py
Refactor Edge service to use properties for service arguments
py/selenium/webdriver/edge/service.py
Mapping
,Optional
, andSequence
.service_args
with_service_args
and added property methods.service.py
Refactor Firefox service to use properties for service arguments
py/selenium/webdriver/firefox/service.py
Mapping
,Optional
, andSequence
.service_args
with_service_args
and added property methods.command_line_args
method to use_service_args
.service.py
Refactor IE service to use properties for service arguments
py/selenium/webdriver/ie/service.py
Optional
andSequence
.service_args
with_service_args
and added property methods.command_line_args
method to use_service_args
.service.py
Refactor Safari service to use properties for service arguments
py/selenium/webdriver/safari/service.py
List
,Mapping
,Optional
, andSequence
.service_args
with_service_args
and added property methods.command_line_args
method to use_service_args
.service.py
Refactor WebKitGTK service to use properties for service arguments
py/selenium/webdriver/webkitgtk/service.py
List
,Mapping
,Optional
, andSequence
.service_args
with_service_args
and added property methods.command_line_args
method to use_service_args
.service.py
Refactor WPEWebKit service to use properties for service arguments
py/selenium/webdriver/wpewebkit/service.py
List
,Mapping
,Optional
, andSequence
.service_args
with_service_args
and added property methods.command_line_args
method to use_service_args
.